defaults_test.go 21 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716
  1. /*
  2. Copyright 2015 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package v1_test
  14. import (
  15. "reflect"
  16. "testing"
  17. "k8s.io/kubernetes/pkg/api"
  18. "k8s.io/kubernetes/pkg/api/resource"
  19. versioned "k8s.io/kubernetes/pkg/api/v1"
  20. "k8s.io/kubernetes/pkg/runtime"
  21. "k8s.io/kubernetes/pkg/util/intstr"
  22. )
  23. func roundTrip(t *testing.T, obj runtime.Object) runtime.Object {
  24. codec := api.Codecs.LegacyCodec(versioned.SchemeGroupVersion)
  25. data, err := runtime.Encode(codec, obj)
  26. if err != nil {
  27. t.Errorf("%v\n %#v", err, obj)
  28. return nil
  29. }
  30. obj2, err := runtime.Decode(codec, data)
  31. if err != nil {
  32. t.Errorf("%v\nData: %s\nSource: %#v", err, string(data), obj)
  33. return nil
  34. }
  35. obj3 := reflect.New(reflect.TypeOf(obj).Elem()).Interface().(runtime.Object)
  36. err = api.Scheme.Convert(obj2, obj3, nil)
  37. if err != nil {
  38. t.Errorf("%v\nSource: %#v", err, obj2)
  39. return nil
  40. }
  41. return obj3
  42. }
  43. func TestSetDefaultReplicationController(t *testing.T) {
  44. tests := []struct {
  45. rc *versioned.ReplicationController
  46. expectLabels bool
  47. expectSelector bool
  48. }{
  49. {
  50. rc: &versioned.ReplicationController{
  51. Spec: versioned.ReplicationControllerSpec{
  52. Template: &versioned.PodTemplateSpec{
  53. ObjectMeta: versioned.ObjectMeta{
  54. Labels: map[string]string{
  55. "foo": "bar",
  56. },
  57. },
  58. },
  59. },
  60. },
  61. expectLabels: true,
  62. expectSelector: true,
  63. },
  64. {
  65. rc: &versioned.ReplicationController{
  66. ObjectMeta: versioned.ObjectMeta{
  67. Labels: map[string]string{
  68. "bar": "foo",
  69. },
  70. },
  71. Spec: versioned.ReplicationControllerSpec{
  72. Template: &versioned.PodTemplateSpec{
  73. ObjectMeta: versioned.ObjectMeta{
  74. Labels: map[string]string{
  75. "foo": "bar",
  76. },
  77. },
  78. },
  79. },
  80. },
  81. expectLabels: false,
  82. expectSelector: true,
  83. },
  84. {
  85. rc: &versioned.ReplicationController{
  86. ObjectMeta: versioned.ObjectMeta{
  87. Labels: map[string]string{
  88. "bar": "foo",
  89. },
  90. },
  91. Spec: versioned.ReplicationControllerSpec{
  92. Selector: map[string]string{
  93. "some": "other",
  94. },
  95. Template: &versioned.PodTemplateSpec{
  96. ObjectMeta: versioned.ObjectMeta{
  97. Labels: map[string]string{
  98. "foo": "bar",
  99. },
  100. },
  101. },
  102. },
  103. },
  104. expectLabels: false,
  105. expectSelector: false,
  106. },
  107. {
  108. rc: &versioned.ReplicationController{
  109. Spec: versioned.ReplicationControllerSpec{
  110. Selector: map[string]string{
  111. "some": "other",
  112. },
  113. Template: &versioned.PodTemplateSpec{
  114. ObjectMeta: versioned.ObjectMeta{
  115. Labels: map[string]string{
  116. "foo": "bar",
  117. },
  118. },
  119. },
  120. },
  121. },
  122. expectLabels: true,
  123. expectSelector: false,
  124. },
  125. }
  126. for _, test := range tests {
  127. rc := test.rc
  128. obj2 := roundTrip(t, runtime.Object(rc))
  129. rc2, ok := obj2.(*versioned.ReplicationController)
  130. if !ok {
  131. t.Errorf("unexpected object: %v", rc2)
  132. t.FailNow()
  133. }
  134. if test.expectSelector != reflect.DeepEqual(rc2.Spec.Selector, rc2.Spec.Template.Labels) {
  135. if test.expectSelector {
  136. t.Errorf("expected: %v, got: %v", rc2.Spec.Template.Labels, rc2.Spec.Selector)
  137. } else {
  138. t.Errorf("unexpected equality: %v", rc.Spec.Selector)
  139. }
  140. }
  141. if test.expectLabels != reflect.DeepEqual(rc2.Labels, rc2.Spec.Template.Labels) {
  142. if test.expectLabels {
  143. t.Errorf("expected: %v, got: %v", rc2.Spec.Template.Labels, rc2.Labels)
  144. } else {
  145. t.Errorf("unexpected equality: %v", rc.Labels)
  146. }
  147. }
  148. }
  149. }
  150. func newInt(val int32) *int32 {
  151. p := new(int32)
  152. *p = val
  153. return p
  154. }
  155. func TestSetDefaultReplicationControllerReplicas(t *testing.T) {
  156. tests := []struct {
  157. rc versioned.ReplicationController
  158. expectReplicas int32
  159. }{
  160. {
  161. rc: versioned.ReplicationController{
  162. Spec: versioned.ReplicationControllerSpec{
  163. Template: &versioned.PodTemplateSpec{
  164. ObjectMeta: versioned.ObjectMeta{
  165. Labels: map[string]string{
  166. "foo": "bar",
  167. },
  168. },
  169. },
  170. },
  171. },
  172. expectReplicas: 1,
  173. },
  174. {
  175. rc: versioned.ReplicationController{
  176. Spec: versioned.ReplicationControllerSpec{
  177. Replicas: newInt(0),
  178. Template: &versioned.PodTemplateSpec{
  179. ObjectMeta: versioned.ObjectMeta{
  180. Labels: map[string]string{
  181. "foo": "bar",
  182. },
  183. },
  184. },
  185. },
  186. },
  187. expectReplicas: 0,
  188. },
  189. {
  190. rc: versioned.ReplicationController{
  191. Spec: versioned.ReplicationControllerSpec{
  192. Replicas: newInt(3),
  193. Template: &versioned.PodTemplateSpec{
  194. ObjectMeta: versioned.ObjectMeta{
  195. Labels: map[string]string{
  196. "foo": "bar",
  197. },
  198. },
  199. },
  200. },
  201. },
  202. expectReplicas: 3,
  203. },
  204. }
  205. for _, test := range tests {
  206. rc := &test.rc
  207. obj2 := roundTrip(t, runtime.Object(rc))
  208. rc2, ok := obj2.(*versioned.ReplicationController)
  209. if !ok {
  210. t.Errorf("unexpected object: %v", rc2)
  211. t.FailNow()
  212. }
  213. if rc2.Spec.Replicas == nil {
  214. t.Errorf("unexpected nil Replicas")
  215. } else if test.expectReplicas != *rc2.Spec.Replicas {
  216. t.Errorf("expected: %d replicas, got: %d", test.expectReplicas, *rc2.Spec.Replicas)
  217. }
  218. }
  219. }
  220. func TestSetDefaultService(t *testing.T) {
  221. svc := &versioned.Service{}
  222. obj2 := roundTrip(t, runtime.Object(svc))
  223. svc2 := obj2.(*versioned.Service)
  224. if svc2.Spec.SessionAffinity != versioned.ServiceAffinityNone {
  225. t.Errorf("Expected default session affinity type:%s, got: %s", versioned.ServiceAffinityNone, svc2.Spec.SessionAffinity)
  226. }
  227. if svc2.Spec.Type != versioned.ServiceTypeClusterIP {
  228. t.Errorf("Expected default type:%s, got: %s", versioned.ServiceTypeClusterIP, svc2.Spec.Type)
  229. }
  230. }
  231. func TestSetDefaultSecretVolumeSource(t *testing.T) {
  232. s := versioned.PodSpec{}
  233. s.Volumes = []versioned.Volume{
  234. {
  235. VolumeSource: versioned.VolumeSource{
  236. Secret: &versioned.SecretVolumeSource{},
  237. },
  238. },
  239. }
  240. pod := &versioned.Pod{
  241. Spec: s,
  242. }
  243. output := roundTrip(t, runtime.Object(pod))
  244. pod2 := output.(*versioned.Pod)
  245. defaultMode := pod2.Spec.Volumes[0].VolumeSource.Secret.DefaultMode
  246. expectedMode := versioned.SecretVolumeSourceDefaultMode
  247. if defaultMode == nil || *defaultMode != expectedMode {
  248. t.Errorf("Expected secret DefaultMode %v, got %v", expectedMode, defaultMode)
  249. }
  250. }
  251. func TestSetDefaultConfigMapVolumeSource(t *testing.T) {
  252. s := versioned.PodSpec{}
  253. s.Volumes = []versioned.Volume{
  254. {
  255. VolumeSource: versioned.VolumeSource{
  256. ConfigMap: &versioned.ConfigMapVolumeSource{},
  257. },
  258. },
  259. }
  260. pod := &versioned.Pod{
  261. Spec: s,
  262. }
  263. output := roundTrip(t, runtime.Object(pod))
  264. pod2 := output.(*versioned.Pod)
  265. defaultMode := pod2.Spec.Volumes[0].VolumeSource.ConfigMap.DefaultMode
  266. expectedMode := versioned.ConfigMapVolumeSourceDefaultMode
  267. if defaultMode == nil || *defaultMode != expectedMode {
  268. t.Errorf("Expected ConfigMap DefaultMode %v, got %v", expectedMode, defaultMode)
  269. }
  270. }
  271. func TestSetDefaultDownwardAPIVolumeSource(t *testing.T) {
  272. s := versioned.PodSpec{}
  273. s.Volumes = []versioned.Volume{
  274. {
  275. VolumeSource: versioned.VolumeSource{
  276. DownwardAPI: &versioned.DownwardAPIVolumeSource{},
  277. },
  278. },
  279. }
  280. pod := &versioned.Pod{
  281. Spec: s,
  282. }
  283. output := roundTrip(t, runtime.Object(pod))
  284. pod2 := output.(*versioned.Pod)
  285. defaultMode := pod2.Spec.Volumes[0].VolumeSource.DownwardAPI.DefaultMode
  286. expectedMode := versioned.DownwardAPIVolumeSourceDefaultMode
  287. if defaultMode == nil || *defaultMode != expectedMode {
  288. t.Errorf("Expected DownwardAPI DefaultMode %v, got %v", expectedMode, defaultMode)
  289. }
  290. }
  291. func TestSetDefaultSecret(t *testing.T) {
  292. s := &versioned.Secret{}
  293. obj2 := roundTrip(t, runtime.Object(s))
  294. s2 := obj2.(*versioned.Secret)
  295. if s2.Type != versioned.SecretTypeOpaque {
  296. t.Errorf("Expected secret type %v, got %v", versioned.SecretTypeOpaque, s2.Type)
  297. }
  298. }
  299. func TestSetDefaultPersistentVolume(t *testing.T) {
  300. pv := &versioned.PersistentVolume{}
  301. obj2 := roundTrip(t, runtime.Object(pv))
  302. pv2 := obj2.(*versioned.PersistentVolume)
  303. if pv2.Status.Phase != versioned.VolumePending {
  304. t.Errorf("Expected volume phase %v, got %v", versioned.VolumePending, pv2.Status.Phase)
  305. }
  306. if pv2.Spec.PersistentVolumeReclaimPolicy != versioned.PersistentVolumeReclaimRetain {
  307. t.Errorf("Expected pv reclaim policy %v, got %v", versioned.PersistentVolumeReclaimRetain, pv2.Spec.PersistentVolumeReclaimPolicy)
  308. }
  309. }
  310. func TestSetDefaultPersistentVolumeClaim(t *testing.T) {
  311. pvc := &versioned.PersistentVolumeClaim{}
  312. obj2 := roundTrip(t, runtime.Object(pvc))
  313. pvc2 := obj2.(*versioned.PersistentVolumeClaim)
  314. if pvc2.Status.Phase != versioned.ClaimPending {
  315. t.Errorf("Expected claim phase %v, got %v", versioned.ClaimPending, pvc2.Status.Phase)
  316. }
  317. }
  318. func TestSetDefaulEndpointsProtocol(t *testing.T) {
  319. in := &versioned.Endpoints{Subsets: []versioned.EndpointSubset{
  320. {Ports: []versioned.EndpointPort{{}, {Protocol: "UDP"}, {}}},
  321. }}
  322. obj := roundTrip(t, runtime.Object(in))
  323. out := obj.(*versioned.Endpoints)
  324. for i := range out.Subsets {
  325. for j := range out.Subsets[i].Ports {
  326. if in.Subsets[i].Ports[j].Protocol == "" {
  327. if out.Subsets[i].Ports[j].Protocol != versioned.ProtocolTCP {
  328. t.Errorf("Expected protocol %s, got %s", versioned.ProtocolTCP, out.Subsets[i].Ports[j].Protocol)
  329. }
  330. } else {
  331. if out.Subsets[i].Ports[j].Protocol != in.Subsets[i].Ports[j].Protocol {
  332. t.Errorf("Expected protocol %s, got %s", in.Subsets[i].Ports[j].Protocol, out.Subsets[i].Ports[j].Protocol)
  333. }
  334. }
  335. }
  336. }
  337. }
  338. func TestSetDefaulServiceTargetPort(t *testing.T) {
  339. in := &versioned.Service{Spec: versioned.ServiceSpec{Ports: []versioned.ServicePort{{Port: 1234}}}}
  340. obj := roundTrip(t, runtime.Object(in))
  341. out := obj.(*versioned.Service)
  342. if out.Spec.Ports[0].TargetPort != intstr.FromInt(1234) {
  343. t.Errorf("Expected TargetPort to be defaulted, got %v", out.Spec.Ports[0].TargetPort)
  344. }
  345. in = &versioned.Service{Spec: versioned.ServiceSpec{Ports: []versioned.ServicePort{{Port: 1234, TargetPort: intstr.FromInt(5678)}}}}
  346. obj = roundTrip(t, runtime.Object(in))
  347. out = obj.(*versioned.Service)
  348. if out.Spec.Ports[0].TargetPort != intstr.FromInt(5678) {
  349. t.Errorf("Expected TargetPort to be unchanged, got %v", out.Spec.Ports[0].TargetPort)
  350. }
  351. }
  352. func TestSetDefaultServicePort(t *testing.T) {
  353. // Unchanged if set.
  354. in := &versioned.Service{Spec: versioned.ServiceSpec{
  355. Ports: []versioned.ServicePort{
  356. {Protocol: "UDP", Port: 9376, TargetPort: intstr.FromString("p")},
  357. {Protocol: "UDP", Port: 8675, TargetPort: intstr.FromInt(309)},
  358. },
  359. }}
  360. out := roundTrip(t, runtime.Object(in)).(*versioned.Service)
  361. if out.Spec.Ports[0].Protocol != versioned.ProtocolUDP {
  362. t.Errorf("Expected protocol %s, got %s", versioned.ProtocolUDP, out.Spec.Ports[0].Protocol)
  363. }
  364. if out.Spec.Ports[0].TargetPort != intstr.FromString("p") {
  365. t.Errorf("Expected port %v, got %v", in.Spec.Ports[0].Port, out.Spec.Ports[0].TargetPort)
  366. }
  367. if out.Spec.Ports[1].Protocol != versioned.ProtocolUDP {
  368. t.Errorf("Expected protocol %s, got %s", versioned.ProtocolUDP, out.Spec.Ports[1].Protocol)
  369. }
  370. if out.Spec.Ports[1].TargetPort != intstr.FromInt(309) {
  371. t.Errorf("Expected port %v, got %v", in.Spec.Ports[1].Port, out.Spec.Ports[1].TargetPort)
  372. }
  373. // Defaulted.
  374. in = &versioned.Service{Spec: versioned.ServiceSpec{
  375. Ports: []versioned.ServicePort{
  376. {Protocol: "", Port: 9376, TargetPort: intstr.FromString("")},
  377. {Protocol: "", Port: 8675, TargetPort: intstr.FromInt(0)},
  378. },
  379. }}
  380. out = roundTrip(t, runtime.Object(in)).(*versioned.Service)
  381. if out.Spec.Ports[0].Protocol != versioned.ProtocolTCP {
  382. t.Errorf("Expected protocol %s, got %s", versioned.ProtocolTCP, out.Spec.Ports[0].Protocol)
  383. }
  384. if out.Spec.Ports[0].TargetPort != intstr.FromInt(int(in.Spec.Ports[0].Port)) {
  385. t.Errorf("Expected port %v, got %v", in.Spec.Ports[0].Port, out.Spec.Ports[0].TargetPort)
  386. }
  387. if out.Spec.Ports[1].Protocol != versioned.ProtocolTCP {
  388. t.Errorf("Expected protocol %s, got %s", versioned.ProtocolTCP, out.Spec.Ports[1].Protocol)
  389. }
  390. if out.Spec.Ports[1].TargetPort != intstr.FromInt(int(in.Spec.Ports[1].Port)) {
  391. t.Errorf("Expected port %v, got %v", in.Spec.Ports[1].Port, out.Spec.Ports[1].TargetPort)
  392. }
  393. }
  394. func TestSetDefaultNamespace(t *testing.T) {
  395. s := &versioned.Namespace{}
  396. obj2 := roundTrip(t, runtime.Object(s))
  397. s2 := obj2.(*versioned.Namespace)
  398. if s2.Status.Phase != versioned.NamespaceActive {
  399. t.Errorf("Expected phase %v, got %v", versioned.NamespaceActive, s2.Status.Phase)
  400. }
  401. }
  402. func TestSetDefaultPodSpecHostNetwork(t *testing.T) {
  403. portNum := int32(8080)
  404. s := versioned.PodSpec{}
  405. s.HostNetwork = true
  406. s.Containers = []versioned.Container{
  407. {
  408. Ports: []versioned.ContainerPort{
  409. {
  410. ContainerPort: portNum,
  411. },
  412. },
  413. },
  414. }
  415. pod := &versioned.Pod{
  416. Spec: s,
  417. }
  418. obj2 := roundTrip(t, runtime.Object(pod))
  419. pod2 := obj2.(*versioned.Pod)
  420. s2 := pod2.Spec
  421. hostPortNum := s2.Containers[0].Ports[0].HostPort
  422. if hostPortNum != portNum {
  423. t.Errorf("Expected container port to be defaulted, was made %d instead of %d", hostPortNum, portNum)
  424. }
  425. }
  426. func TestSetDefaultNodeExternalID(t *testing.T) {
  427. name := "node0"
  428. n := &versioned.Node{}
  429. n.Name = name
  430. obj2 := roundTrip(t, runtime.Object(n))
  431. n2 := obj2.(*versioned.Node)
  432. if n2.Spec.ExternalID != name {
  433. t.Errorf("Expected default External ID: %s, got: %s", name, n2.Spec.ExternalID)
  434. }
  435. if n2.Spec.ProviderID != "" {
  436. t.Errorf("Expected empty default Cloud Provider ID, got: %s", n2.Spec.ProviderID)
  437. }
  438. }
  439. func TestSetDefaultNodeStatusAllocatable(t *testing.T) {
  440. capacity := versioned.ResourceList{
  441. versioned.ResourceCPU: resource.MustParse("1000m"),
  442. versioned.ResourceMemory: resource.MustParse("10G"),
  443. }
  444. allocatable := versioned.ResourceList{
  445. versioned.ResourceCPU: resource.MustParse("500m"),
  446. versioned.ResourceMemory: resource.MustParse("5G"),
  447. }
  448. tests := []struct {
  449. capacity versioned.ResourceList
  450. allocatable versioned.ResourceList
  451. expectedAllocatable versioned.ResourceList
  452. }{{ // Everything set, no defaulting.
  453. capacity: capacity,
  454. allocatable: allocatable,
  455. expectedAllocatable: allocatable,
  456. }, { // Allocatable set, no defaulting.
  457. capacity: nil,
  458. allocatable: allocatable,
  459. expectedAllocatable: allocatable,
  460. }, { // Capacity set, allocatable defaults to capacity.
  461. capacity: capacity,
  462. allocatable: nil,
  463. expectedAllocatable: capacity,
  464. }, { // Nothing set, allocatable "defaults" to capacity.
  465. capacity: nil,
  466. allocatable: nil,
  467. expectedAllocatable: nil,
  468. }}
  469. copyResourceList := func(rl versioned.ResourceList) versioned.ResourceList {
  470. if rl == nil {
  471. return nil
  472. }
  473. copy := make(versioned.ResourceList, len(rl))
  474. for k, v := range rl {
  475. copy[k] = *v.Copy()
  476. }
  477. return copy
  478. }
  479. resourceListsEqual := func(a versioned.ResourceList, b versioned.ResourceList) bool {
  480. if len(a) != len(b) {
  481. return false
  482. }
  483. for k, v := range a {
  484. vb, found := b[k]
  485. if !found {
  486. return false
  487. }
  488. if v.Cmp(vb) != 0 {
  489. return false
  490. }
  491. }
  492. return true
  493. }
  494. for i, testcase := range tests {
  495. node := versioned.Node{
  496. Status: versioned.NodeStatus{
  497. Capacity: copyResourceList(testcase.capacity),
  498. Allocatable: copyResourceList(testcase.allocatable),
  499. },
  500. }
  501. node2 := roundTrip(t, runtime.Object(&node)).(*versioned.Node)
  502. actual := node2.Status.Allocatable
  503. expected := testcase.expectedAllocatable
  504. if !resourceListsEqual(expected, actual) {
  505. t.Errorf("[%d] Expected NodeStatus.Allocatable: %+v; Got: %+v", i, expected, actual)
  506. }
  507. }
  508. }
  509. func TestSetDefaultObjectFieldSelectorAPIVersion(t *testing.T) {
  510. s := versioned.PodSpec{
  511. Containers: []versioned.Container{
  512. {
  513. Env: []versioned.EnvVar{
  514. {
  515. ValueFrom: &versioned.EnvVarSource{
  516. FieldRef: &versioned.ObjectFieldSelector{},
  517. },
  518. },
  519. },
  520. },
  521. },
  522. }
  523. pod := &versioned.Pod{
  524. Spec: s,
  525. }
  526. obj2 := roundTrip(t, runtime.Object(pod))
  527. pod2 := obj2.(*versioned.Pod)
  528. s2 := pod2.Spec
  529. apiVersion := s2.Containers[0].Env[0].ValueFrom.FieldRef.APIVersion
  530. if apiVersion != "v1" {
  531. t.Errorf("Expected default APIVersion v1, got: %v", apiVersion)
  532. }
  533. }
  534. func TestSetDefaultRequestsPod(t *testing.T) {
  535. // verify we default if limits are specified (and that request=0 is preserved)
  536. s := versioned.PodSpec{}
  537. s.Containers = []versioned.Container{
  538. {
  539. Resources: versioned.ResourceRequirements{
  540. Requests: versioned.ResourceList{
  541. versioned.ResourceMemory: resource.MustParse("0"),
  542. },
  543. Limits: versioned.ResourceList{
  544. versioned.ResourceCPU: resource.MustParse("100m"),
  545. versioned.ResourceMemory: resource.MustParse("1Gi"),
  546. },
  547. },
  548. },
  549. }
  550. pod := &versioned.Pod{
  551. Spec: s,
  552. }
  553. output := roundTrip(t, runtime.Object(pod))
  554. pod2 := output.(*versioned.Pod)
  555. defaultRequest := pod2.Spec.Containers[0].Resources.Requests
  556. if requestValue := defaultRequest[versioned.ResourceCPU]; requestValue.String() != "100m" {
  557. t.Errorf("Expected request cpu: %s, got: %s", "100m", requestValue.String())
  558. }
  559. if requestValue := defaultRequest[versioned.ResourceMemory]; requestValue.String() != "0" {
  560. t.Errorf("Expected request memory: %s, got: %s", "0", requestValue.String())
  561. }
  562. // verify we do nothing if no limits are specified
  563. s = versioned.PodSpec{}
  564. s.Containers = []versioned.Container{{}}
  565. pod = &versioned.Pod{
  566. Spec: s,
  567. }
  568. output = roundTrip(t, runtime.Object(pod))
  569. pod2 = output.(*versioned.Pod)
  570. defaultRequest = pod2.Spec.Containers[0].Resources.Requests
  571. if requestValue := defaultRequest[versioned.ResourceCPU]; requestValue.String() != "0" {
  572. t.Errorf("Expected 0 request value, got: %s", requestValue.String())
  573. }
  574. }
  575. func TestDefaultRequestIsNotSetForReplicationController(t *testing.T) {
  576. s := versioned.PodSpec{}
  577. s.Containers = []versioned.Container{
  578. {
  579. Resources: versioned.ResourceRequirements{
  580. Limits: versioned.ResourceList{
  581. versioned.ResourceCPU: resource.MustParse("100m"),
  582. },
  583. },
  584. },
  585. }
  586. rc := &versioned.ReplicationController{
  587. Spec: versioned.ReplicationControllerSpec{
  588. Replicas: newInt(3),
  589. Template: &versioned.PodTemplateSpec{
  590. ObjectMeta: versioned.ObjectMeta{
  591. Labels: map[string]string{
  592. "foo": "bar",
  593. },
  594. },
  595. Spec: s,
  596. },
  597. },
  598. }
  599. output := roundTrip(t, runtime.Object(rc))
  600. rc2 := output.(*versioned.ReplicationController)
  601. defaultRequest := rc2.Spec.Template.Spec.Containers[0].Resources.Requests
  602. requestValue := defaultRequest[versioned.ResourceCPU]
  603. if requestValue.String() != "0" {
  604. t.Errorf("Expected 0 request value, got: %s", requestValue.String())
  605. }
  606. }
  607. func TestSetDefaultLimitRangeItem(t *testing.T) {
  608. limitRange := &versioned.LimitRange{
  609. ObjectMeta: versioned.ObjectMeta{
  610. Name: "test-defaults",
  611. },
  612. Spec: versioned.LimitRangeSpec{
  613. Limits: []versioned.LimitRangeItem{{
  614. Type: versioned.LimitTypeContainer,
  615. Max: versioned.ResourceList{
  616. versioned.ResourceCPU: resource.MustParse("100m"),
  617. },
  618. Min: versioned.ResourceList{
  619. versioned.ResourceMemory: resource.MustParse("100Mi"),
  620. },
  621. Default: versioned.ResourceList{},
  622. DefaultRequest: versioned.ResourceList{},
  623. }},
  624. },
  625. }
  626. output := roundTrip(t, runtime.Object(limitRange))
  627. limitRange2 := output.(*versioned.LimitRange)
  628. defaultLimit := limitRange2.Spec.Limits[0].Default
  629. defaultRequest := limitRange2.Spec.Limits[0].DefaultRequest
  630. // verify that default cpu was set to the max
  631. defaultValue := defaultLimit[versioned.ResourceCPU]
  632. if defaultValue.String() != "100m" {
  633. t.Errorf("Expected default cpu: %s, got: %s", "100m", defaultValue.String())
  634. }
  635. // verify that default request was set to the limit
  636. requestValue := defaultRequest[versioned.ResourceCPU]
  637. if requestValue.String() != "100m" {
  638. t.Errorf("Expected request cpu: %s, got: %s", "100m", requestValue.String())
  639. }
  640. // verify that if a min is provided, it will be the default if no limit is specified
  641. requestMinValue := defaultRequest[versioned.ResourceMemory]
  642. if requestMinValue.String() != "100Mi" {
  643. t.Errorf("Expected request memory: %s, got: %s", "100Mi", requestMinValue.String())
  644. }
  645. }
  646. func TestSetDefaultProbe(t *testing.T) {
  647. originalProbe := versioned.Probe{}
  648. expectedProbe := versioned.Probe{
  649. InitialDelaySeconds: 0,
  650. TimeoutSeconds: 1,
  651. PeriodSeconds: 10,
  652. SuccessThreshold: 1,
  653. FailureThreshold: 3,
  654. }
  655. pod := &versioned.Pod{
  656. Spec: versioned.PodSpec{
  657. Containers: []versioned.Container{{LivenessProbe: &originalProbe}},
  658. },
  659. }
  660. output := roundTrip(t, runtime.Object(pod)).(*versioned.Pod)
  661. actualProbe := *output.Spec.Containers[0].LivenessProbe
  662. if actualProbe != expectedProbe {
  663. t.Errorf("Expected probe: %+v\ngot: %+v\n", expectedProbe, actualProbe)
  664. }
  665. }