json_formatter_test.go 6.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296
  1. package logrus
  2. import (
  3. "encoding/json"
  4. "errors"
  5. "fmt"
  6. "strings"
  7. "testing"
  8. )
  9. func TestErrorNotLost(t *testing.T) {
  10. formatter := &JSONFormatter{}
  11. b, err := formatter.Format(WithField("error", errors.New("wild walrus")))
  12. if err != nil {
  13. t.Fatal("Unable to format entry: ", err)
  14. }
  15. entry := make(map[string]interface{})
  16. err = json.Unmarshal(b, &entry)
  17. if err != nil {
  18. t.Fatal("Unable to unmarshal formatted entry: ", err)
  19. }
  20. if entry["error"] != "wild walrus" {
  21. t.Fatal("Error field not set")
  22. }
  23. }
  24. func TestErrorNotLostOnFieldNotNamedError(t *testing.T) {
  25. formatter := &JSONFormatter{}
  26. b, err := formatter.Format(WithField("omg", errors.New("wild walrus")))
  27. if err != nil {
  28. t.Fatal("Unable to format entry: ", err)
  29. }
  30. entry := make(map[string]interface{})
  31. err = json.Unmarshal(b, &entry)
  32. if err != nil {
  33. t.Fatal("Unable to unmarshal formatted entry: ", err)
  34. }
  35. if entry["omg"] != "wild walrus" {
  36. t.Fatal("Error field not set")
  37. }
  38. }
  39. func TestFieldClashWithTime(t *testing.T) {
  40. formatter := &JSONFormatter{}
  41. b, err := formatter.Format(WithField("time", "right now!"))
  42. if err != nil {
  43. t.Fatal("Unable to format entry: ", err)
  44. }
  45. entry := make(map[string]interface{})
  46. err = json.Unmarshal(b, &entry)
  47. if err != nil {
  48. t.Fatal("Unable to unmarshal formatted entry: ", err)
  49. }
  50. if entry["fields.time"] != "right now!" {
  51. t.Fatal("fields.time not set to original time field")
  52. }
  53. if entry["time"] != "0001-01-01T00:00:00Z" {
  54. t.Fatal("time field not set to current time, was: ", entry["time"])
  55. }
  56. }
  57. func TestFieldClashWithMsg(t *testing.T) {
  58. formatter := &JSONFormatter{}
  59. b, err := formatter.Format(WithField("msg", "something"))
  60. if err != nil {
  61. t.Fatal("Unable to format entry: ", err)
  62. }
  63. entry := make(map[string]interface{})
  64. err = json.Unmarshal(b, &entry)
  65. if err != nil {
  66. t.Fatal("Unable to unmarshal formatted entry: ", err)
  67. }
  68. if entry["fields.msg"] != "something" {
  69. t.Fatal("fields.msg not set to original msg field")
  70. }
  71. }
  72. func TestFieldClashWithLevel(t *testing.T) {
  73. formatter := &JSONFormatter{}
  74. b, err := formatter.Format(WithField("level", "something"))
  75. if err != nil {
  76. t.Fatal("Unable to format entry: ", err)
  77. }
  78. entry := make(map[string]interface{})
  79. err = json.Unmarshal(b, &entry)
  80. if err != nil {
  81. t.Fatal("Unable to unmarshal formatted entry: ", err)
  82. }
  83. if entry["fields.level"] != "something" {
  84. t.Fatal("fields.level not set to original level field")
  85. }
  86. }
  87. func TestFieldClashWithRemappedFields(t *testing.T) {
  88. formatter := &JSONFormatter{
  89. FieldMap: FieldMap{
  90. FieldKeyTime: "@timestamp",
  91. FieldKeyLevel: "@level",
  92. FieldKeyMsg: "@message",
  93. },
  94. }
  95. b, err := formatter.Format(WithFields(Fields{
  96. "@timestamp": "@timestamp",
  97. "@level": "@level",
  98. "@message": "@message",
  99. "timestamp": "timestamp",
  100. "level": "level",
  101. "msg": "msg",
  102. }))
  103. if err != nil {
  104. t.Fatal("Unable to format entry: ", err)
  105. }
  106. entry := make(map[string]interface{})
  107. err = json.Unmarshal(b, &entry)
  108. if err != nil {
  109. t.Fatal("Unable to unmarshal formatted entry: ", err)
  110. }
  111. for _, field := range []string{"timestamp", "level", "msg"} {
  112. if entry[field] != field {
  113. t.Errorf("Expected field %v to be untouched; got %v", field, entry[field])
  114. }
  115. remappedKey := fmt.Sprintf("fields.%s", field)
  116. if remapped, ok := entry[remappedKey]; ok {
  117. t.Errorf("Expected %s to be empty; got %v", remappedKey, remapped)
  118. }
  119. }
  120. for _, field := range []string{"@timestamp", "@level", "@message"} {
  121. if entry[field] == field {
  122. t.Errorf("Expected field %v to be mapped to an Entry value", field)
  123. }
  124. remappedKey := fmt.Sprintf("fields.%s", field)
  125. if remapped, ok := entry[remappedKey]; ok {
  126. if remapped != field {
  127. t.Errorf("Expected field %v to be copied to %s; got %v", field, remappedKey, remapped)
  128. }
  129. } else {
  130. t.Errorf("Expected field %v to be copied to %s; was absent", field, remappedKey)
  131. }
  132. }
  133. }
  134. func TestFieldsInNestedDictionary(t *testing.T) {
  135. formatter := &JSONFormatter{
  136. DataKey: "args",
  137. }
  138. logEntry := WithFields(Fields{
  139. "level": "level",
  140. "test": "test",
  141. })
  142. logEntry.Level = InfoLevel
  143. b, err := formatter.Format(logEntry)
  144. if err != nil {
  145. t.Fatal("Unable to format entry: ", err)
  146. }
  147. entry := make(map[string]interface{})
  148. err = json.Unmarshal(b, &entry)
  149. if err != nil {
  150. t.Fatal("Unable to unmarshal formatted entry: ", err)
  151. }
  152. args := entry["args"].(map[string]interface{})
  153. for _, field := range []string{"test", "level"} {
  154. if value, present := args[field]; !present || value != field {
  155. t.Errorf("Expected field %v to be present under 'args'; untouched", field)
  156. }
  157. }
  158. for _, field := range []string{"test", "fields.level"} {
  159. if _, present := entry[field]; present {
  160. t.Errorf("Expected field %v not to be present at top level", field)
  161. }
  162. }
  163. // with nested object, "level" shouldn't clash
  164. if entry["level"] != "info" {
  165. t.Errorf("Expected 'level' field to contain 'info'")
  166. }
  167. }
  168. func TestJSONEntryEndsWithNewline(t *testing.T) {
  169. formatter := &JSONFormatter{}
  170. b, err := formatter.Format(WithField("level", "something"))
  171. if err != nil {
  172. t.Fatal("Unable to format entry: ", err)
  173. }
  174. if b[len(b)-1] != '\n' {
  175. t.Fatal("Expected JSON log entry to end with a newline")
  176. }
  177. }
  178. func TestJSONMessageKey(t *testing.T) {
  179. formatter := &JSONFormatter{
  180. FieldMap: FieldMap{
  181. FieldKeyMsg: "message",
  182. },
  183. }
  184. b, err := formatter.Format(&Entry{Message: "oh hai"})
  185. if err != nil {
  186. t.Fatal("Unable to format entry: ", err)
  187. }
  188. s := string(b)
  189. if !(strings.Contains(s, "message") && strings.Contains(s, "oh hai")) {
  190. t.Fatal("Expected JSON to format message key")
  191. }
  192. }
  193. func TestJSONLevelKey(t *testing.T) {
  194. formatter := &JSONFormatter{
  195. FieldMap: FieldMap{
  196. FieldKeyLevel: "somelevel",
  197. },
  198. }
  199. b, err := formatter.Format(WithField("level", "something"))
  200. if err != nil {
  201. t.Fatal("Unable to format entry: ", err)
  202. }
  203. s := string(b)
  204. if !strings.Contains(s, "somelevel") {
  205. t.Fatal("Expected JSON to format level key")
  206. }
  207. }
  208. func TestJSONTimeKey(t *testing.T) {
  209. formatter := &JSONFormatter{
  210. FieldMap: FieldMap{
  211. FieldKeyTime: "timeywimey",
  212. },
  213. }
  214. b, err := formatter.Format(WithField("level", "something"))
  215. if err != nil {
  216. t.Fatal("Unable to format entry: ", err)
  217. }
  218. s := string(b)
  219. if !strings.Contains(s, "timeywimey") {
  220. t.Fatal("Expected JSON to format time key")
  221. }
  222. }
  223. func TestJSONDisableTimestamp(t *testing.T) {
  224. formatter := &JSONFormatter{
  225. DisableTimestamp: true,
  226. }
  227. b, err := formatter.Format(WithField("level", "something"))
  228. if err != nil {
  229. t.Fatal("Unable to format entry: ", err)
  230. }
  231. s := string(b)
  232. if strings.Contains(s, FieldKeyTime) {
  233. t.Error("Did not prevent timestamp", s)
  234. }
  235. }
  236. func TestJSONEnableTimestamp(t *testing.T) {
  237. formatter := &JSONFormatter{}
  238. b, err := formatter.Format(WithField("level", "something"))
  239. if err != nil {
  240. t.Fatal("Unable to format entry: ", err)
  241. }
  242. s := string(b)
  243. if !strings.Contains(s, FieldKeyTime) {
  244. t.Error("Timestamp not present", s)
  245. }
  246. }