123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575 |
- /*
- Copyright 2014 The Kubernetes Authors.
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package labels
- import (
- "reflect"
- "strings"
- "testing"
- "k8s.io/kubernetes/pkg/selection"
- "k8s.io/kubernetes/pkg/util/sets"
- )
- func TestSelectorParse(t *testing.T) {
- testGoodStrings := []string{
- "x=a,y=b,z=c",
- "",
- "x!=a,y=b",
- "x=",
- "x= ",
- "x=,z= ",
- "x= ,z= ",
- "!x",
- "x>1",
- "x>1,z<5",
- }
- testBadStrings := []string{
- "x=a||y=b",
- "x==a==b",
- "!x=a",
- "x<a",
- }
- for _, test := range testGoodStrings {
- lq, err := Parse(test)
- if err != nil {
- t.Errorf("%v: error %v (%#v)\n", test, err, err)
- }
- if strings.Replace(test, " ", "", -1) != lq.String() {
- t.Errorf("%v restring gave: %v\n", test, lq.String())
- }
- }
- for _, test := range testBadStrings {
- _, err := Parse(test)
- if err == nil {
- t.Errorf("%v: did not get expected error\n", test)
- }
- }
- }
- func TestDeterministicParse(t *testing.T) {
- s1, err := Parse("x=a,a=x")
- s2, err2 := Parse("a=x,x=a")
- if err != nil || err2 != nil {
- t.Errorf("Unexpected parse error")
- }
- if s1.String() != s2.String() {
- t.Errorf("Non-deterministic parse")
- }
- }
- func expectMatch(t *testing.T, selector string, ls Set) {
- lq, err := Parse(selector)
- if err != nil {
- t.Errorf("Unable to parse %v as a selector\n", selector)
- return
- }
- if !lq.Matches(ls) {
- t.Errorf("Wanted %s to match '%s', but it did not.\n", selector, ls)
- }
- }
- func expectNoMatch(t *testing.T, selector string, ls Set) {
- lq, err := Parse(selector)
- if err != nil {
- t.Errorf("Unable to parse %v as a selector\n", selector)
- return
- }
- if lq.Matches(ls) {
- t.Errorf("Wanted '%s' to not match '%s', but it did.", selector, ls)
- }
- }
- func TestEverything(t *testing.T) {
- if !Everything().Matches(Set{"x": "y"}) {
- t.Errorf("Nil selector didn't match")
- }
- if !Everything().Empty() {
- t.Errorf("Everything was not empty")
- }
- }
- func TestSelectorMatches(t *testing.T) {
- expectMatch(t, "", Set{"x": "y"})
- expectMatch(t, "x=y", Set{"x": "y"})
- expectMatch(t, "x=y,z=w", Set{"x": "y", "z": "w"})
- expectMatch(t, "x!=y,z!=w", Set{"x": "z", "z": "a"})
- expectMatch(t, "notin=in", Set{"notin": "in"}) // in and notin in exactMatch
- expectMatch(t, "x", Set{"x": "z"})
- expectMatch(t, "!x", Set{"y": "z"})
- expectMatch(t, "x>1", Set{"x": "2"})
- expectMatch(t, "x<1", Set{"x": "0"})
- expectNoMatch(t, "x=z", Set{})
- expectNoMatch(t, "x=y", Set{"x": "z"})
- expectNoMatch(t, "x=y,z=w", Set{"x": "w", "z": "w"})
- expectNoMatch(t, "x!=y,z!=w", Set{"x": "z", "z": "w"})
- expectNoMatch(t, "x", Set{"y": "z"})
- expectNoMatch(t, "!x", Set{"x": "z"})
- expectNoMatch(t, "x>1", Set{"x": "0"})
- expectNoMatch(t, "x<1", Set{"x": "2"})
- labelset := Set{
- "foo": "bar",
- "baz": "blah",
- }
- expectMatch(t, "foo=bar", labelset)
- expectMatch(t, "baz=blah", labelset)
- expectMatch(t, "foo=bar,baz=blah", labelset)
- expectNoMatch(t, "foo=blah", labelset)
- expectNoMatch(t, "baz=bar", labelset)
- expectNoMatch(t, "foo=bar,foobar=bar,baz=blah", labelset)
- }
- func expectMatchDirect(t *testing.T, selector, ls Set) {
- if !SelectorFromSet(selector).Matches(ls) {
- t.Errorf("Wanted %s to match '%s', but it did not.\n", selector, ls)
- }
- }
- func expectNoMatchDirect(t *testing.T, selector, ls Set) {
- if SelectorFromSet(selector).Matches(ls) {
- t.Errorf("Wanted '%s' to not match '%s', but it did.", selector, ls)
- }
- }
- func TestSetMatches(t *testing.T) {
- labelset := Set{
- "foo": "bar",
- "baz": "blah",
- }
- expectMatchDirect(t, Set{}, labelset)
- expectMatchDirect(t, Set{"foo": "bar"}, labelset)
- expectMatchDirect(t, Set{"baz": "blah"}, labelset)
- expectMatchDirect(t, Set{"foo": "bar", "baz": "blah"}, labelset)
- //TODO: bad values not handled for the moment in SelectorFromSet
- //expectNoMatchDirect(t, Set{"foo": "=blah"}, labelset)
- //expectNoMatchDirect(t, Set{"baz": "=bar"}, labelset)
- //expectNoMatchDirect(t, Set{"foo": "=bar", "foobar": "bar", "baz": "blah"}, labelset)
- }
- func TestNilMapIsValid(t *testing.T) {
- selector := Set(nil).AsSelector()
- if selector == nil {
- t.Errorf("Selector for nil set should be Everything")
- }
- if !selector.Empty() {
- t.Errorf("Selector for nil set should be Empty")
- }
- }
- func TestSetIsEmpty(t *testing.T) {
- if !(Set{}).AsSelector().Empty() {
- t.Errorf("Empty set should be empty")
- }
- if !(NewSelector()).Empty() {
- t.Errorf("Nil Selector should be empty")
- }
- }
- func TestLexer(t *testing.T) {
- testcases := []struct {
- s string
- t Token
- }{
- {"", EndOfStringToken},
- {",", CommaToken},
- {"notin", NotInToken},
- {"in", InToken},
- {"=", EqualsToken},
- {"==", DoubleEqualsToken},
- {">", GreaterThanToken},
- {"<", LessThanToken},
- //Note that Lex returns the longest valid token found
- {"!", DoesNotExistToken},
- {"!=", NotEqualsToken},
- {"(", OpenParToken},
- {")", ClosedParToken},
- //Non-"special" characters are considered part of an identifier
- {"~", IdentifierToken},
- {"||", IdentifierToken},
- }
- for _, v := range testcases {
- l := &Lexer{s: v.s, pos: 0}
- token, lit := l.Lex()
- if token != v.t {
- t.Errorf("Got %d it should be %d for '%s'", token, v.t, v.s)
- }
- if v.t != ErrorToken && lit != v.s {
- t.Errorf("Got '%s' it should be '%s'", lit, v.s)
- }
- }
- }
- func min(l, r int) (m int) {
- m = r
- if l < r {
- m = l
- }
- return m
- }
- func TestLexerSequence(t *testing.T) {
- testcases := []struct {
- s string
- t []Token
- }{
- {"key in ( value )", []Token{IdentifierToken, InToken, OpenParToken, IdentifierToken, ClosedParToken}},
- {"key notin ( value )", []Token{IdentifierToken, NotInToken, OpenParToken, IdentifierToken, ClosedParToken}},
- {"key in ( value1, value2 )", []Token{IdentifierToken, InToken, OpenParToken, IdentifierToken, CommaToken, IdentifierToken, ClosedParToken}},
- {"key", []Token{IdentifierToken}},
- {"!key", []Token{DoesNotExistToken, IdentifierToken}},
- {"()", []Token{OpenParToken, ClosedParToken}},
- {"x in (),y", []Token{IdentifierToken, InToken, OpenParToken, ClosedParToken, CommaToken, IdentifierToken}},
- {"== != (), = notin", []Token{DoubleEqualsToken, NotEqualsToken, OpenParToken, ClosedParToken, CommaToken, EqualsToken, NotInToken}},
- {"key>2", []Token{IdentifierToken, GreaterThanToken, IdentifierToken}},
- {"key<1", []Token{IdentifierToken, LessThanToken, IdentifierToken}},
- }
- for _, v := range testcases {
- var literals []string
- var tokens []Token
- l := &Lexer{s: v.s, pos: 0}
- for {
- token, lit := l.Lex()
- if token == EndOfStringToken {
- break
- }
- tokens = append(tokens, token)
- literals = append(literals, lit)
- }
- if len(tokens) != len(v.t) {
- t.Errorf("Bad number of tokens for '%s %d, %d", v.s, len(tokens), len(v.t))
- }
- for i := 0; i < min(len(tokens), len(v.t)); i++ {
- if tokens[i] != v.t[i] {
- t.Errorf("Test '%s': Mismatching in token type found '%v' it should be '%v'", v.s, tokens[i], v.t[i])
- }
- }
- }
- }
- func TestParserLookahead(t *testing.T) {
- testcases := []struct {
- s string
- t []Token
- }{
- {"key in ( value )", []Token{IdentifierToken, InToken, OpenParToken, IdentifierToken, ClosedParToken, EndOfStringToken}},
- {"key notin ( value )", []Token{IdentifierToken, NotInToken, OpenParToken, IdentifierToken, ClosedParToken, EndOfStringToken}},
- {"key in ( value1, value2 )", []Token{IdentifierToken, InToken, OpenParToken, IdentifierToken, CommaToken, IdentifierToken, ClosedParToken, EndOfStringToken}},
- {"key", []Token{IdentifierToken, EndOfStringToken}},
- {"!key", []Token{DoesNotExistToken, IdentifierToken, EndOfStringToken}},
- {"()", []Token{OpenParToken, ClosedParToken, EndOfStringToken}},
- {"", []Token{EndOfStringToken}},
- {"x in (),y", []Token{IdentifierToken, InToken, OpenParToken, ClosedParToken, CommaToken, IdentifierToken, EndOfStringToken}},
- {"== != (), = notin", []Token{DoubleEqualsToken, NotEqualsToken, OpenParToken, ClosedParToken, CommaToken, EqualsToken, NotInToken, EndOfStringToken}},
- {"key>2", []Token{IdentifierToken, GreaterThanToken, IdentifierToken, EndOfStringToken}},
- {"key<1", []Token{IdentifierToken, LessThanToken, IdentifierToken, EndOfStringToken}},
- }
- for _, v := range testcases {
- p := &Parser{l: &Lexer{s: v.s, pos: 0}, position: 0}
- p.scan()
- if len(p.scannedItems) != len(v.t) {
- t.Errorf("Expected %d items found %d", len(v.t), len(p.scannedItems))
- }
- for {
- token, lit := p.lookahead(KeyAndOperator)
- token2, lit2 := p.consume(KeyAndOperator)
- if token == EndOfStringToken {
- break
- }
- if token != token2 || lit != lit2 {
- t.Errorf("Bad values")
- }
- }
- }
- }
- func TestRequirementConstructor(t *testing.T) {
- requirementConstructorTests := []struct {
- Key string
- Op selection.Operator
- Vals sets.String
- Success bool
- }{
- {"x", selection.In, nil, false},
- {"x", selection.NotIn, sets.NewString(), false},
- {"x", selection.In, sets.NewString("foo"), true},
- {"x", selection.NotIn, sets.NewString("foo"), true},
- {"x", selection.Exists, nil, true},
- {"x", selection.DoesNotExist, nil, true},
- {"1foo", selection.In, sets.NewString("bar"), true},
- {"1234", selection.In, sets.NewString("bar"), true},
- {"y", selection.GreaterThan, sets.NewString("1"), true},
- {"z", selection.LessThan, sets.NewString("6"), true},
- {"foo", selection.GreaterThan, sets.NewString("bar"), false},
- {"barz", selection.LessThan, sets.NewString("blah"), false},
- {strings.Repeat("a", 254), selection.Exists, nil, false}, //breaks DNS rule that len(key) <= 253
- }
- for _, rc := range requirementConstructorTests {
- if _, err := NewRequirement(rc.Key, rc.Op, rc.Vals); err == nil && !rc.Success {
- t.Errorf("expected error with key:%#v op:%v vals:%v, got no error", rc.Key, rc.Op, rc.Vals)
- } else if err != nil && rc.Success {
- t.Errorf("expected no error with key:%#v op:%v vals:%v, got:%v", rc.Key, rc.Op, rc.Vals, err)
- }
- }
- }
- func TestToString(t *testing.T) {
- var req Requirement
- toStringTests := []struct {
- In *internalSelector
- Out string
- Valid bool
- }{
- {&internalSelector{
- getRequirement("x", selection.In, sets.NewString("abc", "def"), t),
- getRequirement("y", selection.NotIn, sets.NewString("jkl"), t),
- getRequirement("z", selection.Exists, nil, t)},
- "x in (abc,def),y notin (jkl),z", true},
- {&internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString("abc", "def"), t),
- getRequirement("y", selection.NotEquals, sets.NewString("jkl"), t),
- getRequirement("z", selection.DoesNotExist, nil, t)},
- "x notin (abc,def),y!=jkl,!z", true},
- {&internalSelector{
- getRequirement("x", selection.In, sets.NewString("abc", "def"), t),
- req}, // adding empty req for the trailing ','
- "x in (abc,def),", false},
- {&internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString("abc"), t),
- getRequirement("y", selection.In, sets.NewString("jkl", "mno"), t),
- getRequirement("z", selection.NotIn, sets.NewString(""), t)},
- "x notin (abc),y in (jkl,mno),z notin ()", true},
- {&internalSelector{
- getRequirement("x", selection.Equals, sets.NewString("abc"), t),
- getRequirement("y", selection.DoubleEquals, sets.NewString("jkl"), t),
- getRequirement("z", selection.NotEquals, sets.NewString("a"), t),
- getRequirement("z", selection.Exists, nil, t)},
- "x=abc,y==jkl,z!=a,z", true},
- {&internalSelector{
- getRequirement("x", selection.GreaterThan, sets.NewString("2"), t),
- getRequirement("y", selection.LessThan, sets.NewString("8"), t),
- getRequirement("z", selection.Exists, nil, t)},
- "x>2,y<8,z", true},
- }
- for _, ts := range toStringTests {
- if out := ts.In.String(); out == "" && ts.Valid {
- t.Errorf("%#v.String() => '%v' expected no error", ts.In, out)
- } else if out != ts.Out {
- t.Errorf("%#v.String() => '%v' want '%v'", ts.In, out, ts.Out)
- }
- }
- }
- func TestRequirementSelectorMatching(t *testing.T) {
- var req Requirement
- labelSelectorMatchingTests := []struct {
- Set Set
- Sel Selector
- Match bool
- }{
- {Set{"x": "foo", "y": "baz"}, &internalSelector{
- req,
- }, false},
- {Set{"x": "foo", "y": "baz"}, &internalSelector{
- getRequirement("x", selection.In, sets.NewString("foo"), t),
- getRequirement("y", selection.NotIn, sets.NewString("alpha"), t),
- }, true},
- {Set{"x": "foo", "y": "baz"}, &internalSelector{
- getRequirement("x", selection.In, sets.NewString("foo"), t),
- getRequirement("y", selection.In, sets.NewString("alpha"), t),
- }, false},
- {Set{"y": ""}, &internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString(""), t),
- getRequirement("y", selection.Exists, nil, t),
- }, true},
- {Set{"y": ""}, &internalSelector{
- getRequirement("x", selection.DoesNotExist, nil, t),
- getRequirement("y", selection.Exists, nil, t),
- }, true},
- {Set{"y": ""}, &internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString(""), t),
- getRequirement("y", selection.DoesNotExist, nil, t),
- }, false},
- {Set{"y": "baz"}, &internalSelector{
- getRequirement("x", selection.In, sets.NewString(""), t),
- }, false},
- {Set{"z": "2"}, &internalSelector{
- getRequirement("z", selection.GreaterThan, sets.NewString("1"), t),
- }, true},
- {Set{"z": "v2"}, &internalSelector{
- getRequirement("z", selection.GreaterThan, sets.NewString("1"), t),
- }, false},
- }
- for _, lsm := range labelSelectorMatchingTests {
- if match := lsm.Sel.Matches(lsm.Set); match != lsm.Match {
- t.Errorf("%+v.Matches(%#v) => %v, want %v", lsm.Sel, lsm.Set, match, lsm.Match)
- }
- }
- }
- func TestSetSelectorParser(t *testing.T) {
- setSelectorParserTests := []struct {
- In string
- Out Selector
- Match bool
- Valid bool
- }{
- {"", NewSelector(), true, true},
- {"\rx", internalSelector{
- getRequirement("x", selection.Exists, nil, t),
- }, true, true},
- {"this-is-a-dns.domain.com/key-with-dash", internalSelector{
- getRequirement("this-is-a-dns.domain.com/key-with-dash", selection.Exists, nil, t),
- }, true, true},
- {"this-is-another-dns.domain.com/key-with-dash in (so,what)", internalSelector{
- getRequirement("this-is-another-dns.domain.com/key-with-dash", selection.In, sets.NewString("so", "what"), t),
- }, true, true},
- {"0.1.2.domain/99 notin (10.10.100.1, tick.tack.clock)", internalSelector{
- getRequirement("0.1.2.domain/99", selection.NotIn, sets.NewString("10.10.100.1", "tick.tack.clock"), t),
- }, true, true},
- {"foo in (abc)", internalSelector{
- getRequirement("foo", selection.In, sets.NewString("abc"), t),
- }, true, true},
- {"x notin\n (abc)", internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString("abc"), t),
- }, true, true},
- {"x notin \t (abc,def)", internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString("abc", "def"), t),
- }, true, true},
- {"x in (abc,def)", internalSelector{
- getRequirement("x", selection.In, sets.NewString("abc", "def"), t),
- }, true, true},
- {"x in (abc,)", internalSelector{
- getRequirement("x", selection.In, sets.NewString("abc", ""), t),
- }, true, true},
- {"x in ()", internalSelector{
- getRequirement("x", selection.In, sets.NewString(""), t),
- }, true, true},
- {"x notin (abc,,def),bar,z in (),w", internalSelector{
- getRequirement("bar", selection.Exists, nil, t),
- getRequirement("w", selection.Exists, nil, t),
- getRequirement("x", selection.NotIn, sets.NewString("abc", "", "def"), t),
- getRequirement("z", selection.In, sets.NewString(""), t),
- }, true, true},
- {"x,y in (a)", internalSelector{
- getRequirement("y", selection.In, sets.NewString("a"), t),
- getRequirement("x", selection.Exists, nil, t),
- }, false, true},
- {"x=a", internalSelector{
- getRequirement("x", selection.Equals, sets.NewString("a"), t),
- }, true, true},
- {"x>1", internalSelector{
- getRequirement("x", selection.GreaterThan, sets.NewString("1"), t),
- }, true, true},
- {"x<7", internalSelector{
- getRequirement("x", selection.LessThan, sets.NewString("7"), t),
- }, true, true},
- {"x=a,y!=b", internalSelector{
- getRequirement("x", selection.Equals, sets.NewString("a"), t),
- getRequirement("y", selection.NotEquals, sets.NewString("b"), t),
- }, true, true},
- {"x=a,y!=b,z in (h,i,j)", internalSelector{
- getRequirement("x", selection.Equals, sets.NewString("a"), t),
- getRequirement("y", selection.NotEquals, sets.NewString("b"), t),
- getRequirement("z", selection.In, sets.NewString("h", "i", "j"), t),
- }, true, true},
- {"x=a||y=b", internalSelector{}, false, false},
- {"x,,y", nil, true, false},
- {",x,y", nil, true, false},
- {"x nott in (y)", nil, true, false},
- {"x notin ( )", internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString(""), t),
- }, true, true},
- {"x notin (, a)", internalSelector{
- getRequirement("x", selection.NotIn, sets.NewString("", "a"), t),
- }, true, true},
- {"a in (xyz),", nil, true, false},
- {"a in (xyz)b notin ()", nil, true, false},
- {"a ", internalSelector{
- getRequirement("a", selection.Exists, nil, t),
- }, true, true},
- {"a in (x,y,notin, z,in)", internalSelector{
- getRequirement("a", selection.In, sets.NewString("in", "notin", "x", "y", "z"), t),
- }, true, true}, // operator 'in' inside list of identifiers
- {"a in (xyz abc)", nil, false, false}, // no comma
- {"a notin(", nil, true, false}, // bad formed
- {"a (", nil, false, false}, // cpar
- {"(", nil, false, false}, // opar
- }
- for _, ssp := range setSelectorParserTests {
- if sel, err := Parse(ssp.In); err != nil && ssp.Valid {
- t.Errorf("Parse(%s) => %v expected no error", ssp.In, err)
- } else if err == nil && !ssp.Valid {
- t.Errorf("Parse(%s) => %+v expected error", ssp.In, sel)
- } else if ssp.Match && !reflect.DeepEqual(sel, ssp.Out) {
- t.Errorf("Parse(%s) => parse output '%#v' doesn't match '%#v' expected match", ssp.In, sel, ssp.Out)
- }
- }
- }
- func getRequirement(key string, op selection.Operator, vals sets.String, t *testing.T) Requirement {
- req, err := NewRequirement(key, op, vals)
- if err != nil {
- t.Errorf("NewRequirement(%v, %v, %v) resulted in error:%v", key, op, vals, err)
- return Requirement{}
- }
- return *req
- }
- func TestAdd(t *testing.T) {
- testCases := []struct {
- name string
- sel Selector
- key string
- operator selection.Operator
- values []string
- refSelector Selector
- }{
- {
- "keyInOperator",
- internalSelector{},
- "key",
- selection.In,
- []string{"value"},
- internalSelector{Requirement{"key", selection.In, sets.NewString("value")}},
- },
- {
- "keyEqualsOperator",
- internalSelector{Requirement{"key", selection.In, sets.NewString("value")}},
- "key2",
- selection.Equals,
- []string{"value2"},
- internalSelector{
- Requirement{"key", selection.In, sets.NewString("value")},
- Requirement{"key2", selection.Equals, sets.NewString("value2")},
- },
- },
- }
- for _, ts := range testCases {
- req, err := NewRequirement(ts.key, ts.operator, sets.NewString(ts.values...))
- if err != nil {
- t.Errorf("%s - Unable to create labels.Requirement", ts.name)
- }
- ts.sel = ts.sel.Add(*req)
- if !reflect.DeepEqual(ts.sel, ts.refSelector) {
- t.Errorf("%s - Expected %v found %v", ts.name, ts.refSelector, ts.sel)
- }
- }
- }
|