v2_test.go 5.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228
  1. /*
  2. Copyright 2016 The Kubernetes Authors.
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. http://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package remotecommand
  14. import (
  15. "errors"
  16. "io"
  17. "net/http"
  18. "strings"
  19. "testing"
  20. "time"
  21. "k8s.io/kubernetes/pkg/api"
  22. "k8s.io/kubernetes/pkg/util/httpstream"
  23. "k8s.io/kubernetes/pkg/util/wait"
  24. )
  25. type fakeReader struct {
  26. err error
  27. }
  28. func (r *fakeReader) Read([]byte) (int, error) { return 0, r.err }
  29. type fakeWriter struct{}
  30. func (*fakeWriter) Write([]byte) (int, error) { return 0, nil }
  31. type fakeStreamCreator struct {
  32. created map[string]bool
  33. errors map[string]error
  34. }
  35. var _ streamCreator = &fakeStreamCreator{}
  36. func (f *fakeStreamCreator) CreateStream(headers http.Header) (httpstream.Stream, error) {
  37. streamType := headers.Get(api.StreamType)
  38. f.created[streamType] = true
  39. return nil, f.errors[streamType]
  40. }
  41. func TestV2CreateStreams(t *testing.T) {
  42. tests := []struct {
  43. name string
  44. stdin bool
  45. stdinError error
  46. stdout bool
  47. stdoutError error
  48. stderr bool
  49. stderrError error
  50. errorError error
  51. tty bool
  52. expectError bool
  53. }{
  54. {
  55. name: "stdin error",
  56. stdin: true,
  57. stdinError: errors.New("stdin error"),
  58. expectError: true,
  59. },
  60. {
  61. name: "stdout error",
  62. stdout: true,
  63. stdoutError: errors.New("stdout error"),
  64. expectError: true,
  65. },
  66. {
  67. name: "stderr error",
  68. stderr: true,
  69. stderrError: errors.New("stderr error"),
  70. expectError: true,
  71. },
  72. {
  73. name: "error stream error",
  74. stdin: true,
  75. stdout: true,
  76. stderr: true,
  77. errorError: errors.New("error stream error"),
  78. expectError: true,
  79. },
  80. {
  81. name: "no errors",
  82. stdin: true,
  83. stdout: true,
  84. stderr: true,
  85. expectError: false,
  86. },
  87. {
  88. name: "no errors, stderr & tty set, don't expect stderr",
  89. stdin: true,
  90. stdout: true,
  91. stderr: true,
  92. tty: true,
  93. expectError: false,
  94. },
  95. }
  96. for _, test := range tests {
  97. conn := &fakeStreamCreator{
  98. created: make(map[string]bool),
  99. errors: map[string]error{
  100. api.StreamTypeStdin: test.stdinError,
  101. api.StreamTypeStdout: test.stdoutError,
  102. api.StreamTypeStderr: test.stderrError,
  103. api.StreamTypeError: test.errorError,
  104. },
  105. }
  106. opts := StreamOptions{Tty: test.tty}
  107. if test.stdin {
  108. opts.Stdin = &fakeReader{}
  109. }
  110. if test.stdout {
  111. opts.Stdout = &fakeWriter{}
  112. }
  113. if test.stderr {
  114. opts.Stderr = &fakeWriter{}
  115. }
  116. h := newStreamProtocolV2(opts).(*streamProtocolV2)
  117. err := h.createStreams(conn)
  118. if test.expectError {
  119. if err == nil {
  120. t.Errorf("%s: expected error", test.name)
  121. continue
  122. }
  123. if e, a := test.stdinError, err; test.stdinError != nil && e != a {
  124. t.Errorf("%s: expected %v, got %v", test.name, e, a)
  125. }
  126. if e, a := test.stdoutError, err; test.stdoutError != nil && e != a {
  127. t.Errorf("%s: expected %v, got %v", test.name, e, a)
  128. }
  129. if e, a := test.stderrError, err; test.stderrError != nil && e != a {
  130. t.Errorf("%s: expected %v, got %v", test.name, e, a)
  131. }
  132. if e, a := test.errorError, err; test.errorError != nil && e != a {
  133. t.Errorf("%s: expected %v, got %v", test.name, e, a)
  134. }
  135. continue
  136. }
  137. if !test.expectError && err != nil {
  138. t.Errorf("%s: unexpected error: %v", test.name, err)
  139. continue
  140. }
  141. if test.stdin && !conn.created[api.StreamTypeStdin] {
  142. t.Errorf("%s: expected stdin stream", test.name)
  143. }
  144. if test.stdout && !conn.created[api.StreamTypeStdout] {
  145. t.Errorf("%s: expected stdout stream", test.name)
  146. }
  147. if test.stderr {
  148. if test.tty && conn.created[api.StreamTypeStderr] {
  149. t.Errorf("%s: unexpected stderr stream because tty is set", test.name)
  150. } else if !test.tty && !conn.created[api.StreamTypeStderr] {
  151. t.Errorf("%s: expected stderr stream", test.name)
  152. }
  153. }
  154. if !conn.created[api.StreamTypeError] {
  155. t.Errorf("%s: expected error stream", test.name)
  156. }
  157. }
  158. }
  159. func TestV2ErrorStreamReading(t *testing.T) {
  160. tests := []struct {
  161. name string
  162. stream io.Reader
  163. expectedError error
  164. }{
  165. {
  166. name: "error reading from stream",
  167. stream: &fakeReader{errors.New("foo")},
  168. expectedError: errors.New("error reading from error stream: foo"),
  169. },
  170. {
  171. name: "stream returns an error",
  172. stream: strings.NewReader("some error"),
  173. expectedError: errors.New("error executing remote command: some error"),
  174. },
  175. }
  176. for _, test := range tests {
  177. h := newStreamProtocolV2(StreamOptions{}).(*streamProtocolV2)
  178. h.errorStream = test.stream
  179. ch := watchErrorStream(h.errorStream, &errorDecoderV2{})
  180. if ch == nil {
  181. t.Fatalf("%s: unexpected nil channel", test.name)
  182. }
  183. var err error
  184. select {
  185. case err = <-ch:
  186. case <-time.After(wait.ForeverTestTimeout):
  187. t.Fatalf("%s: timed out", test.name)
  188. }
  189. if test.expectedError != nil {
  190. if err == nil {
  191. t.Errorf("%s: expected an error", test.name)
  192. } else if e, a := test.expectedError, err; e.Error() != a.Error() {
  193. t.Errorf("%s: expected %q, got %q", test.name, e, a)
  194. }
  195. continue
  196. }
  197. if test.expectedError == nil && err != nil {
  198. t.Errorf("%s: unexpected error: %v", test.name, err)
  199. continue
  200. }
  201. }
  202. }